Re: [PATCH v2] ARM: PL011: Add support for Rx DMA buffer polling

[Linus Walleij]

On Mon, Jan 28, 2013 at 9:15 AM, Chanho Min <chanho.min@xxxxxxx> wrote:
> [Russell]
>>Well, I thought I had explained that I'd prefer to see the poll rate
>>adjusted with the baud rate, but maybe I wasn't explicit enough.
>>Instead, what we seem to have ended up with are two new entries in
>>platform data (which we're trying to get away from with DT):
>>
>>+       unsigned int dma_rx_poll_rate;
>>+       unsigned int dma_rx_poll_timeout;
>>
>>If this were to be done, then receive DMA could be used on the Versatile
>>PB platforms without having it suck CPU usage unnecessarily at slower
>>baud rates.
> This patch is working well on our pl011+ pl080 platform.
> If no data is received during time-out, no tick timer works.
> Do you want to adjust the poll rate with the baud rate additionally?

I'm not following, you wrote earlier in the thread:

>>Should we scale the polling interval according to baud
>>rate?
>
> It is also our concern, I will suggest the proper way.

We are waiting for you suggestion, i.e. a new patch iteration
taking this into account.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/