Re: [PATCH 3/3] ALSA: intel8x0: Check return value before assigning

[H. Peter Anvin]

Wtf?
 
This patch seems semibogus at best and the description is even more ridiculous...

Emil Goode <emilgoode@xxxxxxxxx> wrote:

>The first patch in this series changes the return type of function
>kvm_para_available to bool. In the function snd_intel8x0_inside_vm
>we now need to check it's return value before assigning a value to
>the result variable.
>
>Signed-off-by: Emil Goode <emilgoode@xxxxxxxxx>
>---
> sound/pci/intel8x0.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/sound/pci/intel8x0.c b/sound/pci/intel8x0.c
>index 3b9be75..fa9337e 100644
>--- a/sound/pci/intel8x0.c
>+++ b/sound/pci/intel8x0.c
>@@ -2982,7 +2982,7 @@ static int snd_intel8x0_inside_vm(struct pci_dev
>*pci)
> 	}
> 
> 	/* detect KVM and Parallels virtual environments */
>-	result = kvm_para_available();
>+	result = kvm_para_available() ? 1 : 0;
> #ifdef X86_FEATURE_HYPERVISOR
> 	result = result || boot_cpu_has(X86_FEATURE_HYPERVISOR);
> #endif

-- 
Sent from my mobile phone. Please excuse brevity and lack of formatting.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/