Re: [PATCH] block/partition/msdos: detect AIX formatted disks evenwithout 55aa

[Andreas Mohr]

Hi,

IMHO that patch would better have a small but important one-liner comment
(one cannot rely on people always making use of SCM history functionality,
thereby this would be at risk of getting reversed accidentally eventually).

E.g.

/* Note order! (some AIX disks, e.g. unbootable kind, have no MSDOS 55aa) */

	if (aix_magic_present(state, data)) {
.
.
.


Apart from that: nice compat catch!

HTH,

Andreas Mohr

-- 
GNU/Linux. It's not the software that's free, it's you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/