[perf PATCH 3/3] Fix double fclose() on do_write(fd, xxx) failure

From: Thomas Jarosch
Date: Fri Jan 25 2013 - 05:22:27 EST


cppcheck reported:
[util/header.c:983]: (error) Used file that is not opened.

Signed-off-by: Thomas Jarosch <thomas.jarosch@xxxxxxxxxxxxx>
---
tools/perf/util/header.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
index 7b24cf3..30745c2 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -955,6 +955,7 @@ static int write_topo_node(int fd, int node)
}

fclose(fp);
+ fp = NULL;

ret = do_write(fd, &mem_total, sizeof(u64));
if (ret)
--
1.7.11.7

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/