Re: [PATCHv2] tools lib traceevent: Handle dynamic array's elementsize properly

From: Arnaldo Carvalho de Melo
Date: Thu Jan 24 2013 - 17:58:37 EST


Em Thu, Jan 24, 2013 at 04:33:05PM -0500, Steven Rostedt escreveu:
> On Thu, 2013-01-24 at 18:28 -0300, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Jan 24, 2013 at 04:13:13PM -0500, Steven Rostedt escreveu:
> > > On Thu, 2013-01-24 at 21:46 +0100, Jiri Olsa wrote:
> > > >
> > > > +static unsigned int type_size(char *name)
> > >
> > > Sorry to nitpick, but please make that const char *name.
> >
> > Agreed, no need to resubmit, I'll fix that up.
>
> I'm sure Tom St Denis appreciates it.
>
> >
> > > The rest looks good.
> >
> > Thanks, adding your Acked-by,
>
> Sure. But I probably should test it too ;-)

ROFL

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/