Re: [PATCH v2] sched: Fix print format for u64

From: Ingo Molnar
Date: Thu Jan 24 2013 - 09:19:21 EST



* Fabio Estevam <festevam@xxxxxxxxx> wrote:

> Hi Ingo,
>
> On Tue, Dec 25, 2012 at 9:24 AM, Fabio Estevam <festevam@xxxxxxxxx> wrote:
> > From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> >
> > commit c566e8e9 (sched: Aggregate total task_group load) introduced the
> > following build warning:
> >
> > kernel/sched/debug.c:225:2: warning: format '%ld' expects argument of type 'long int', but argument 4 has type 'u64' [-Wformat]
> > kernel/sched/debug.c:225:2: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'u64' [-Wformat]
> >
> > Use %llu format to print a u64 value as per Documentation/printk-formats.txt.
> >
> > Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
>
> Does this one look good?

I suppose - is this patch warning-free both on 64-bit and 32-bit
systems?

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/