Re: [PATCH v2 2/6] sched: split out css_online/css_offline from tgcreation/destruction

From: Ingo Molnar
Date: Thu Jan 24 2013 - 05:04:26 EST



* Li Zefan <lizefan@xxxxxxxxxx> wrote:

> extern struct task_group *sched_create_group(struct task_group *parent);
> +extern void sched_online_group(struct task_group *tg,
> + struct task_group *parent);
> extern void sched_destroy_group(struct task_group *tg);
> +extern void sched_offline_group(struct task_group *tg);

Btw., a rename of these APIs might be in order, along the usual
patterns:

sched_task_group_create()
sched_task_group_online()
sched_task_group_offline()
sched_task_group_destroy()

etc.

that way the naming is more hierarchical and there's no clash
with the sched_group concept which is about something else.

(In a separate patch.)

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/