Re: [PATCH v2 3/4] dw_dmac: fill individual length of descriptor

From: Viresh Kumar
Date: Wed Jan 23 2013 - 23:48:11 EST


On Wed, Jan 23, 2013 at 9:07 PM, Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> It will be useful to have the length of the transfer in the descriptor. The
> cyclic transfer functions remained untouched.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> drivers/dma/dw_dmac.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
> index c3062a5..026a3c7 100644
> --- a/drivers/dma/dw_dmac.c
> +++ b/drivers/dma/dw_dmac.c
> @@ -756,6 +756,7 @@ dwc_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dest, dma_addr_t src,
> desc->lli.dar = dest + offset;
> desc->lli.ctllo = ctllo;
> desc->lli.ctlhi = xfer_count;
> + desc->len = xfer_count << src_width;
>
> if (!first) {
> first = desc;
> @@ -852,8 +853,8 @@ slave_sg_todev_fill_desc:
> dlen = len;
> len = 0;
> }
> -

:(

> desc->lli.ctlhi = dlen >> mem_width;
> + desc->len = dlen;
>
> if (!first) {
> first = desc;
> @@ -912,6 +913,7 @@ slave_sg_fromdev_fill_desc:
> len = 0;
> }
> desc->lli.ctlhi = dlen >> reg_width;
> + desc->len = dlen;
>
> if (!first) {
> first = desc;

After fixing that.

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/