Re: [PATCH 1/2] leds-lp5521: fix a build warning

[Bryan Wu]

On Wed, Jan 23, 2013 at 7:08 AM, Nathan Lynch <ntl@xxxxxxxxx> wrote:
> On Wed, 2013-01-23 at 08:07 +0000, Kim, Milo wrote:
>> This patch removes a build warning below.(ARCH=x86_64)
>>
>> drivers/leds/leds-lp5521.c: In function lp5521_firmware_loaded:
>> drivers/leds/leds-lp5521.c:257:4: warning: format %d expects argument of type in
>> t, but argument 3 has type size_t [-Wformat]
>>
>> Signed-off-by: Milo(Woogyom) Kim <milo.kim@xxxxxx>
>> ---
>>  drivers/leds/leds-lp5521.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/leds/leds-lp5521.c b/drivers/leds/leds-lp5521.c
>> index 80adfb4..74946f4 100644
>> --- a/drivers/leds/leds-lp5521.c
>> +++ b/drivers/leds/leds-lp5521.c
>> @@ -253,7 +253,7 @@ static void lp5521_firmware_loaded(struct lp55xx_chip *chip)
>>       const struct firmware *fw = chip->fw;
>>
>>       if (fw->size > LP5521_PROGRAM_LENGTH) {
>> -             dev_err(&chip->cl->dev, "firmware data size overflow: %d\n",
>> +             dev_err(&chip->cl->dev, "firmware data size overflow: %zd\n",
>>                       fw->size);
>
> Documentation/printk-formats.txt says %zu is to be used for size_t.
>
> Same comment goes for patch 2/2.
>
>

I agree with Nathan here. It should be %zu and %zd is for ssize_t.
Please update and fold these 2 patches into one, Milo.

Thanks,
-Bryan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/