Re: [PATCH 3.8-rc4-nohz3] kvm: Add missing include and EXPORT_SYMBOL_GPL

[Sedat Dilek]

On Wed, Jan 23, 2013 at 5:14 PM, Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:
> 2013/1/23 Sedat Dilek <sedat.dilek@xxxxxxxxx>:
>> When CONFIG_KVM=m my build with 3.8-rc4-nohz3 breaks like this:
>>
>> ERROR: "guest_enter" [arch/x86/kvm/kvm.ko] undefined!
>> ERROR: "guest_exit" [arch/x86/kvm/kvm.ko] undefined!
>>
>> Fix this by removing the CONFIG_KVM ifdefs and adding missing
>> EXPORT_SYMBOL_GPL for:
>> + guest_enter() and guest_exit()
>> + vtime_guest_enter() and vtime_guest_exit()
>>
>> Also add a missing include:
>> + Add <linux/export.h> to kernel/context_tracking.c
>>
>> This issue was introduced with commit 8eebafe9be58 ("kvm: Prepare to
>> add generic guest entry/exit callbacks").
>>
>> With some help of funny "iâ"X86 hackerz!
>>
>> Tested on a Ubuntu/precise AMD64 with 'CONFIG_KVM=m'.
>>
>> [ vUNKNOWN: Without the magic "i" hack. -dileks ]
>> [ vUNKNOWN+1: Remove vtime.h from kvm_host.h. -dileks ]
>>
>> Signed-off-by: Sedat Dilek <sedat.dilek@xxxxxxxxx>
>
> Thanks you!
>
> I hope you don't mind if I fold this patch into 8eebafe9be58. If I
> apply your patch separately, my patch would break the bisection.
> But I'll add your signed-off and the appropriate co-authorship credits.

That sounds reasonable! Thanks for the vital help... Enjoyed it :-).

- Sedat -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/