Re: [ANNOUNCE] 3.8-rc4-nohz3

From: Sedat Dilek
Date: Wed Jan 23 2013 - 07:14:09 EST


On Wed, Jan 23, 2013 at 1:11 PM, Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:
> 2013/1/23 Sedat Dilek <sedat.dilek@xxxxxxxxx>:
>> On Wed, Jan 23, 2013 at 12:19 PM, Sedat Dilek <sedat.dilek@xxxxxxxxx> wrote:
>>> Hi Frederic,
>>>
>>> I wanted to 3.8-rc4-nohz3 [1] here on my Ubuntu/precise AMD64 system.
>>>
>>> Unfortunately, the build breaks like this:
>>>
>>> ERROR: "guest_enter" [arch/x86/kvm/kvm.ko] undefined!
>>> ERROR: "guest_exit" [arch/x86/kvm/kvm.ko] undefined!
>>>
>>
>> Looks like you tested with CONFIG_KVM=y (as module fails!).
>
> Yep. looks like I forgot some EXPORT_SYMBOL().
>

Hmmm, that was my first thought, too, but about...

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index c243b81..fff0932 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -5713,7 +5713,7 @@ static int vcpu_enter_guest(struct kvm_vcpu *vcpu)
if (req_immediate_exit)
smp_send_reschedule(vcpu->cpu);

- kvm_guest_enter();
+ guest_enter();

if (unlikely(vcpu->arch.switch_db_regs)) {
set_debugreg(0, 7);


...this?

- Sedat -

> Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/