Re: linux-next: build warning after merge of the akpm tree

From: Tang Chen
Date: Wed Jan 23 2013 - 01:43:38 EST


On 01/23/2013 02:33 PM, Stephen Rothwell wrote:
Hi Andrew,

After merging the akpm tree, today's linux-next build (arm defconfig)
produced this warning:

mm/page_alloc.c:4477:23: warning: 'sanitize_zone_movable_limit' defined but not used [-Wunused-function]

Introduced by commit "page_alloc: introduce zone_movable_limit[] to keep
movable limit for nodes" from the akpm tree. It is defined both when
CONFIG_HAVE_MEMBLOCK_NODE_MAP is defined and not, but only used if it is
defined.


Hi Stephen,

Thank you for reporting this. :)

I was aware of this problem by the kbuild rebot, and I think this problem has been fixed
by the following patch I sent yesterday, and merged into -mm tree this morning.

Since I could access the lkml web site today, I cannot get an url for you.
Please tell me if your problem is not solved after applying this patch. :)

Thanks. :)


[PATCH Bug fix 3/4] Bug fix: Remove the unused sanitize_zone_movable_limit() definition.

When CONFIG_HAVE_MEMBLOCK_NODE_MAP is not defined, sanitize_zone_movable_limit()
is also not used. So remove it.

Signed-off-by: Tang Chen <tangchen@xxxxxxxxxxxxxx>
---
mm/page_alloc.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index cd6f8a6..2bd529e 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -4459,11 +4459,6 @@ static inline unsigned long __meminit zone_absent_pages_in_node(int nid,

return zholes_size[zone_type];
}
-
-static void __meminit sanitize_zone_movable_limit(void)
-{
-}
-
#endif /* CONFIG_HAVE_MEMBLOCK_NODE_MAP */

static void __meminit calculate_node_totalpages(struct pglist_data *pgdat,
-- 1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/