Re: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type

[kishon]

On Tuesday 22 January 2013 10:32 PM, Koen Kooi wrote:
> Op 22 jan. 2013, om 17:16 heeft kishon <kishon@xxxxxx> het volgende geschreven:
>
> > Hi,
> >
> > On Tuesday 22 January 2013 09:15 PM, kishon wrote:
> > > On Tuesday 22 January 2013 09:11 PM, Koen Kooi wrote:
> > > > Op 22 jan. 2013, om 10:58 heeft Kishon Vijay Abraham I <kishon@xxxxxx>
> > > > het volgende geschreven:
> > > >
> > > > > This patch series adds support for adding multiple PHY's (of same type).
> > > > > The binding information has to be present in the PHY library (otg.c) in
> > > > > order for it to return the appropriate PHY whenever the USB controller
> > > > > request for the PHY. So added a new API usb_bind_phy() to pass the
> > > > > binding
> > > > > information. This API should be called by platform specific
> > > > > initialization
> > > > > code.
> > > > >
> > > > > So the binding should be done something like
> > > > > usb_bind_phy("musb-hdrc.0.auto", 0, "omap-usb2.1.auto"); specifying
> > > > > the USB
> > > > > controller device name, index, and the PHY device name.
> > > > > I have done this binding for OMAP platforms, but it should be done for
> > > > > all the platforms.
> > > > >
> > > > > After this design, the phy can be got by passing the USB controller
> > > > > device
> > > > > pointer and the index.
> > > > >
> > > > > Developed this patch series on
> > > > > git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git xceiv
> > > > > after applying "usb: musb: add driver for control module" patch series
> > > > > and "ARM: dts: omap: add dt data for MUSB"
> > > > >
> > > > > Did basic enumeration testing in omap4 panda and omap3 beagle.
> > > >
> > > > With this patchset USB completely breaks on am33xx beaglebone, is that
> > > > intended?
> > > Not really.
> > > Does am33xx makes use of omap2430.c? Which PHY does am33xx uses?
> >
> > I figured out it uses drivers/usb/musb/musb_dsps.c (So it doesn't use omap2430.c). I think it uses TWL4030_USB (TPS659x0) as PHY.
>
> Actually it uses nop-phy as a phy, which is missing from arch/arm/boot/dts/am33xx.dtsi, so mainline is already broken. But adding the nop-phy to the DT is easy enough to patch in locally.

Cool. You can add your patch after applying this series then. (I'll post 
a new version addressing the comments in this series.)

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/