Re: [PATCH v2] ARM: PL011: Add support for Rx DMA buffer polling

From: Chanho Min
Date: Wed Jan 23 2013 - 00:07:44 EST


On Tue, Jan 22, 2013 at 10:18 PM, Linus Walleij
<linus.walleij@xxxxxxxxxx> wrote:
>> - If poll timer is activated, We use consistent DMA mappings to avoid from
>> the frequent cache operation of the timer function. sg->coherency is used
>> to check if buffer is coherent.
>
> Hm. We can begin like this but maybe we should later patch it to
> make this the default unless it has performance impacts on our
> systems.
Good, I really hope to make this the default.
We expect it has no impact to system even if no polling use.

> Maybe this is a good opportunity to add some kerneldoc above
> this struct so as to help platform implementers. It will invariably
> be reused by Device Tree binding authors later on...
Agree, but, frankly I need help about what I didn't modify.
So We will leave this work for the next submit.

Thanks
Chanho
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/