Re: [PATCH] MAX_PAUSE to be at least 4

[Jan Kara]

On Mon 21-01-13 14:07:34, paul.szabo@xxxxxxxxxxxxx wrote:
> Ensure MAX_PAUSE is 4 or larger, so limits in
> 	return clamp_val(t, 4, MAX_PAUSE);
> (the only use of it) are not back-to-front.
> 
> (This patch does not solve the PAE OOM issue.)
> 
> Paul Szabo   psz@xxxxxxxxxxxxxxxxx   http://www.maths.usyd.edu.au/u/psz/
> School of Mathematics and Statistics   University of Sydney    Australia
  I guess this isn't needed in patch changelog?

  Also clamp_val(t, 4, MAX_PAUSE) doesn't seem to exist anymore?

								Honza
> Reported-by: Paul Szabo <psz@xxxxxxxxxxxxxxxxx>
> Reference: http://bugs.debian.org/695182
> Signed-off-by: Paul Szabo <psz@xxxxxxxxxxxxxxxxx>
> 
> --- mm/page-writeback.c.old	2012-12-06 22:20:40.000000000 +1100
> +++ mm/page-writeback.c	2013-01-21 13:57:05.000000000 +1100
> @@ -39,7 +39,7 @@
>  /*
>   * Sleep at most 200ms at a time in balance_dirty_pages().
>   */
> -#define MAX_PAUSE		max(HZ/5, 1)
> +#define MAX_PAUSE		max(HZ/5, 4)
>  
>  /*
>   * Estimate write bandwidth at 200ms intervals.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/