RE: [PATCH] staging/comedi: Use comedi_pci_auto_unconfig directlyfor pci_driver.remove

[H Hartley Sweeten]

On Tuesday, January 22, 2013 3:40 PM, Peter Huewe wrote:
>  (Almost) all comedi pci drivers have some wrapper for their
> pci_driver.remove function which simply calls comedi_pci_auto_unconfig
> which has the same function prototype as the wrapper.
>
> -> we can remove these wrappers and call comedi_pci_auto_unconfig
> directly. This removes a lot some boilerplate code and saves some bytes.
>
> Signed-off-by: Peter Huewe <peterhuewe@xxxxxx>
> ---
> Maybe we should move the implementation now to drivers.c,
> because now it cannot be inlined anymore. 
> This would save some more bytes in the .kos but comedi_pci_auto_unconfig
> then has to become an exported symbol.

Did you build this?

As you mention above, the inlined comedi_pci_auto_unconfig() will not
work as a function pointer in the pci_driver structs.

This cannot work until/if comedi_pci_auto_unconfig() is made an exported
symbol. I'll leave that decision up to Ian.

Regards,
Hartley

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/