Re: [PATCH] Add module aliases for acpi-cpufreq

From: Borislav Petkov
Date: Tue Jan 22 2013 - 12:35:29 EST


On Tue, Jan 22, 2013 at 11:42:24AM -0500, Matthew Garrett wrote:
> The acpi core will call request_module("acpi-cpufreq") on subsystem init,
> but this will fail if the module isn't available at that stage of boot.
> Add some module aliases to ensure that udev can load the module on Intel
> and AMD systems with the appropriate feature bits - I /think/ that this
> will also work on VIA systems, but haven't verified that.
>
> Signed-off-by: Matthew Garrett <matthew.garrett@xxxxxxxxxx>

Let's add some more tags:

Link: http://lkml.kernel.org/r/1448223.sdUJnNSRz4@xxxxxxxxxxxxxx
Tested-by: Leonid Isaev <lisaev@xxxxxxxxxxxx>
Acked-by: Borislav Petkov <bp@xxxxxxx>

Rafael, this is all yours. :-)

Thanks.

> ---
> drivers/cpufreq/acpi-cpufreq.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
> index 0d048f6..7b0d49d 100644
> --- a/drivers/cpufreq/acpi-cpufreq.c
> +++ b/drivers/cpufreq/acpi-cpufreq.c
> @@ -1030,4 +1030,11 @@ MODULE_PARM_DESC(acpi_pstate_strict,
> late_initcall(acpi_cpufreq_init);
> module_exit(acpi_cpufreq_exit);
>
> +static const struct x86_cpu_id acpi_cpufreq_ids[] = {
> + X86_FEATURE_MATCH(X86_FEATURE_ACPI),
> + X86_FEATURE_MATCH(X86_FEATURE_HW_PSTATE),
> + {}
> +};
> +MODULE_DEVICE_TABLE(x86cpu, acpi_cpufreq_ids);
> +
> MODULE_ALIAS("acpi");
> --
> 1.8.0.2
>
>

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/