[PATCH 3/4] pwm_backlight: Refactor the DT parsing code

From: Peter Ujfalusi
Date: Tue Jan 22 2013 - 08:40:41 EST


In preparation to support the whole range of the PWM device in a similar way
it is possible when we boot in legacy mode (non DT mode).

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx>
---
drivers/video/backlight/pwm_bl.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
index 2a81c24..df2d115 100644
--- a/drivers/video/backlight/pwm_bl.c
+++ b/drivers/video/backlight/pwm_bl.c
@@ -100,7 +100,7 @@ static int pwm_backlight_parse_dt(struct device *dev,
{
struct device_node *node = dev->of_node;
struct property *prop;
- int length;
+ int num_levels = 0;
u32 value;
int ret;

@@ -110,26 +110,27 @@ static int pwm_backlight_parse_dt(struct device *dev,
memset(data, 0, sizeof(*data));

/* determine the number of brightness levels */
- prop = of_find_property(node, "brightness-levels", &length);
+ prop = of_find_property(node, "brightness-levels", &num_levels);
if (!prop)
return -EINVAL;

- data->max_brightness = length / sizeof(u32);
+ num_levels /= sizeof(u32);

/* read brightness levels from DT property */
- if (data->max_brightness > 0) {
- size_t size = sizeof(*data->levels) * data->max_brightness;
+ if (num_levels > 0) {
+ size_t size = sizeof(*data->levels) * num_levels;

data->levels = devm_kzalloc(dev, size, GFP_KERNEL);
if (!data->levels)
return -ENOMEM;

ret = of_property_read_u32_array(node, "brightness-levels",
- data->levels,
- data->max_brightness);
+ data->levels, num_levels);
if (ret < 0)
return ret;

+ data->max_brightness = num_levels;
+
ret = of_property_read_u32(node, "default-brightness-level",
&value);
if (ret < 0)
--
1.8.1.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/