Re: [PATCH] of: dma.c: fix memory leakage

From: Cong Ding
Date: Tue Jan 22 2013 - 05:10:47 EST


On Sun, Jan 20, 2013 at 04:24:49PM -0600, Rob Herring wrote:
> On 01/19/2013 07:06 AM, Cong Ding wrote:
> > The memory allocated to ofdma might be a leakage when error occurs.
> >
> > Signed-off-by: Cong Ding <dinggnu@xxxxxxxxx>
>
> You need to send this to whomever is working on DMA bindings.
Thank you bob, I added Vinod the the receiver list.

- cong

>
> > ---
> > drivers/of/dma.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/of/dma.c b/drivers/of/dma.c
> > index 59631b2..583e50e3 100644
> > --- a/drivers/of/dma.c
> > +++ b/drivers/of/dma.c
> > @@ -107,6 +107,7 @@ int of_dma_controller_register(struct device_node *np,
> > if (!nbcells) {
> > pr_err("%s: #dma-cells property is missing or invalid\n",
> > __func__);
> > + kfree(ofdma);
> > return -EINVAL;
> > }
> >
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/