Re: [PATCH v2 2/2] backlight: add new lp8788 backlight driver

[Samuel Ortiz]

Hi,

On Fri, Dec 21, 2012 at 07:55:23AM +0000, Kim, Milo wrote:
> TI LP8788 PMU supports regulators, battery charger, RTC, ADC, backlight driver
> and current sinks.
> This patch enables LP8788 backlight module.
> 
> (Brightness mode)
> The brightness is controlled by PWM input or I2C register.
> All modes are supported in the driver.
> 
> (Platform data)
> Configurable data can be defined in the platform side.
>  name                  : backlight driver name. (default: "lcd-backlight")
>  initial_brightness    : initial value of backlight brightness
>  bl_mode               : brightness control by PWM or lp8788 register
>  dim_mode              : dimming mode selection
>  full_scale            : full scale current setting
>  rise_time             : brightness ramp up step time
>  fall_time             : brightness ramp down step time
>  pwm_pol               : PWM polarity setting when bl_mode is PWM based
>  period_ns             : platform specific PWM period value. unit is nano.
> 
> The default values are set in case no platform data is defined.
> 
> Patch v2.
>  use generic PWM functions rather than lp8788 platform data function calls.
>  add configurable PWM period in the platform data.
>  replace module_init() and module_exit() with module_platform_driver().
> 
> Patch v1.
>  initial patch
> 
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@xxxxxx>
> ---
>  drivers/video/backlight/Kconfig     |    6 +
>  drivers/video/backlight/Makefile    |    1 +
>  drivers/video/backlight/lp8788_bl.c |  350 +++++++++++++++++++++++++++++++++++
>  include/linux/mfd/lp8788.h          |   16 +-
For the MFD parts:

Acked-by: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/