Re: [PATCH 12/15] USB: gadget/freescale: disable non-multiplatformdrivers

[Felipe Balbi]

Hi,

On Mon, Jan 21, 2013 at 05:16:05PM +0000, Arnd Bergmann wrote:
> Both the fsl_mxc gadget and the imx_udc gadget drivers fail to build
> without the mach/hardware.h file that is not available when building
> for multiplatform. Let's disable these drivers for v3.8 in combination
> with CONFIG_ARCH_MULTIPLATFORM, and fix them properly in v3.9 unless
> someone has an better solution.
> 
> Without this patch, building allyesconfig results in:
> 
> drivers/usb/gadget/fsl_mxc_udc.c:21:27: fatal error: mach/hardware.h: No such file or directory
> 
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Felipe Balbi <balbi@xxxxxx>
> Cc: Shawn Guo <shawn.guo@xxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: linux-usb@xxxxxxxxxxxxxxx

NAK, I prefer to see a real fix for the problem (which in fact is
already in my fixes branch).

Next time, before enabling something by default, check that
allyesconfig, allmodconfig and allnoconfig builds fine, please.

-- 
balbi

Attachment: signature.asc
Description: Digital signature