Re: USB: storage: optimize the matching rules and support new switchcommand for Huawei USB storage devices

[Greg KH]

On Mon, Jan 21, 2013 at 03:41:20AM +0000, Fangxiaozhi (Franko) wrote:
> Dear Greg:
> 
> > -----Original Message-----
> > From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx]
> > Sent: Saturday, January 19, 2013 7:42 AM
> > To: Fangxiaozhi (Franko)
> > Cc: linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Xueguiying (Zihan);
> > Linlei (Lei Lin); Yili (Neil); Wangyuhua (Roger, Credit); Huqiao (C); balbi@xxxxxx;
> > mdharm-usb@xxxxxxxxxxxxxxxxxx; sebastian@xxxxxxxxxxxxx
> > Subject: Re: USB: storage: optimize the matching rules and support new switch
> > command for Huawei USB storage devices
> > 
> > On Mon, Jan 14, 2013 at 10:55:48AM +0800, fangxiaozhi 00110321 wrote:
> > >
> > > From: fangxiaozhi <huananhu@xxxxxxxxxx>
> > >
> > > 1. Optimize the matching rules with new macro for Huawei USB storage
> > >    devices, to avoid to load USB storage driver for the modem interface
> > >    with Huawei devices.
> > > 2. Add to support new switch command for new Huawei USB dongles.
> > >
> > > Signed-off-by: fangxiaozhi <huananhu@xxxxxxxxxx>
> > 
> > Next time, please always use the scripts/checkpatch.pl tool to find any
> > problems you might have made in your patch (you had trailing whitespace in
> > this one, which I have fixed.)
> > 
> -----Yes, I have checked my patch with scripts/checkpatch.pl tool before submitting.

Then where did the trailing whitespace come from?

> -----For this trailing whitespace error, I think that it is better
> readable to leave whitespace in our patch code. Isn't it?

Not at the end of lines for no reason, right?

Please fix up and resend.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/