Re: [PATCH v2 69/76] ARC: [Review] Multi-platform image #2: Boardcallback Infrastructure

[Vineet Gupta]

On Friday 18 January 2013 08:35 PM, Arnd Bergmann wrote:
> On Friday 18 January 2013, Vineet Gupta wrote:
>> +struct machine_desc {
>> +	const char		*name;
>> +	const char		**dt_compat;
>> +
>> +	void			(*init_early)(void);
>> +	void			(*init_irq)(void);
>> +	void			(*init_time)(void);
>> +	void			(*init_machine)(void);
>> +	void			(*init_late)(void);
>> +
>> +#ifdef CONFIG_SMP
>> +	void			(*init_smp)(unsigned int);
>> +#endif
> On ARM, it turned out helpful to list these in the order in 
> which they get called. I assume that at least init_smp
> is currently not in that order.

Rightly so, which is fixed now. I also kept forgetting hence the big comment above
actually describes the exact location from where the callback is invoked. Note
that init_smp is called for each cpu.

> Also, we are slowly making some of these obsolete on
> ARM: For platforms that at DT-only, the timer and
> irq code is now in drivers/irqchip and drivers/clocksource
> and can get automatically initialized.

OK - I'll make a note. BTW init_time was a recent addition, the reason being it's
timing. For registering a clocksource, init_irq and init_smp are too early
(timekeeping not yet up) while init_machine (arch initcall) seemed too late - but
thinking again, it could well be done in there. I need to check with the relevant
platform folks.

> It probably makese sense for you to keep the above structure
> for now, but you can also think about obsoleting some
> of the calls in the future. It may be a good idea to have
> a default version for each of these but still allow overriding
> them for maximum flexibility in the platform.
>
> 	Arnd

IMHO the default has to be NULL, unless the platform has a quirk. It would be
cleaner (and easier to read) if any default was factored out into ARC common code.

-Vineet
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/