Re: [patch v1 2/5] regulator: da9055 change irq state to default

From: Mark Brown
Date: Mon Jan 21 2013 - 03:13:35 EST


On Mon, Jan 21, 2013 at 01:34:18PM +0530, Ashish Jangam wrote:
> > On Fri, Jan 18, 2013 at 10:52:45AM +0530, Ashish Jangam wrote:

> > > This patch changes the irq state from high to the now default low
> > > state.

> > > This patch is dependent on the DA9055 MFD.

> > Why is this change required and why is there a dependency here?

> It has been decided to have nIRQ therefore the main mfd IRQ state needs

Won't this break all existing systems?

> to be changed. And since mfd children follows mfd irq state therefore
> the dependency; though in case of mfd this may not affect.

What makes you say that there is a dependency here? It's really not at
all obvious why a change to the primary IRQ signalling mechanism would
affect the internal interrupts of the device.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/