Re: IPsec AH use of ahash

From: Tom St Denis
Date: Sun Jan 20 2013 - 19:40:36 EST




----- Original Message -----
> From: "Borislav Petkov" <bp@xxxxxxxxx>
> To: "Steven Rostedt" <rostedt@xxxxxxxxxxx>
> Cc: "Tom St Denis" <tstdenis@xxxxxxxxxxxxxxxx>, "David Dillow" <dave@xxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx,
> netdev@xxxxxxxxxxxxxxx
> Sent: Sunday, 20 January, 2013 7:34:41 PM
> Subject: Re: IPsec AH use of ahash
>
> On Sun, Jan 20, 2013 at 05:54:07PM -0500, Steven Rostedt wrote:
> > My God, you sound like a 2 year old.
> >
> > Suck it up, and do the fixes. It's not the time you are worried
> > about,
> > as you most definitely spent more time bitching to everyone than it
> > would have taken you to clean up your work.
>
> It's like you're reading my mind... :-)

The problem is for me to add the ()'s is a no brainer.

For me to re-write complete statements for coding style reasons means I have to actually go out and test it again. In a proper IPsec lab that can take a couple of hours to make sure it's been run through its paces. That's [among other things] the problem I have. Re-writing perfectly good code because it doesn't meet coding "standards" that nobody else seems to match.

If you guys can't appreciate that I should just bow out of the discussion. I didn't come here looking for a fight I came here to seek reason.

Tom
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/