Re: [PATCH] firewire net: Ensure checksumming in upper layer.

From: Stephan Gatzka
Date: Sun Jan 20 2013 - 09:46:41 EST



Indeed neither the device nor the lower drivers check protocol checksums.
But the CRCs of the encapsulating 1394 packets are checked in hardware.
Shall protocol checksums be verified regardless?

Yes, because packets may come from off-link source.


Hm, I can't see any off-link packets coming from fwnet_finish_incoming_packet()

So I wont verify checksums in the driver.

Stephan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/