Re: IPsec AH use of ahash

[Tom St Denis]

----- Original Message -----
> From: "Borislav Petkov" <bp@xxxxxxxxx>
> To: "Mike Galbraith" <bitbucket@xxxxxxxxx>
> Cc: "Tom St Denis" <tstdenis@xxxxxxxxxxxxxxxx>, "Eric Dumazet" <erdnetdev@xxxxxxxxx>, "Waskiewicz Jr, Peter P"
> <peter.p.waskiewicz.jr@xxxxxxxxx>, "David Miller" <davem@xxxxxxxxxxxxx>, "steffen klassert"
> <steffen.klassert@xxxxxxxxxxx>, herbert@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx,
> "Michal Kubecek" <mkubecek@xxxxxxx>
> Sent: Sunday, 20 January, 2013 5:31:32 AM
> Subject: Re: IPsec AH use of ahash
> 
> On Sun, Jan 20, 2013 at 06:06:21AM +0100, Mike Galbraith wrote:
> > Sounds as though any patches you submit land on your dinner plate
> > just
> > like potatoes. Hand the cook a pot of half peeled potatoes, he/she
> > may
> > say try again.
> 
> And how he/she would say it! I've seen serious fights spring up from
> half-peeled potatoes so people better peel them right the first time.

You should really try running checkpatch.pl over code that's already in the kernel before you call out new contributors on it.

How is this supposed to not be adversarial when I can't even use the Kernel source itself as a reference?

Tom
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/