Re: [PATCH] Staging: zcache-main: Fixed Camel Case Issue

[Cong Ding]

On Fri, Jan 18, 2013 at 09:56:44PM -0500, Jake Champlin wrote:
> Fixed a camel case coding style issue.
> 
> Signed-off-by: Jake Champlin <jake.champlin.27@xxxxxxxxx>
> ---
>  drivers/staging/zcache/zcache-main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/zcache/zcache-main.c b/drivers/staging/zcache/zcache-main.c
> index 52b43b7..95be348 100644
> --- a/drivers/staging/zcache/zcache-main.c
> +++ b/drivers/staging/zcache/zcache-main.c
> @@ -1851,7 +1851,7 @@ static int zcache_frontswap_store(unsigned type, pgoff_t offset,
>  	int ret = -1;
>  	unsigned long flags;
>  
> -	BUG_ON(!PageLocked(page));
> +	BUG_ON(!page_locked(page));
>  	if (likely(ind64 == ind)) {
>  		local_irq_save(flags);
>  		ret = zcache_put_page(LOCAL_CLIENT, zcache_frontswap_poolid,
> @@ -1871,7 +1871,7 @@ static int zcache_frontswap_load(unsigned type, pgoff_t offset,
>  	struct tmem_oid oid = oswiz(type, ind);
>  	int ret = -1;
>  
> -	BUG_ON(!PageLocked(page));
> +	BUG_ON(!page_locked(page));

again, that doesn't work. Did you try to build the code?

- cong

>  	if (likely(ind64 == ind))
>  		ret = zcache_get_page(LOCAL_CLIENT, zcache_frontswap_poolid,
>  					&oid, iswiz(ind), page);
> -- 
> 1.8.1.1
> 
> 
> -- 
> Jake Champlin
> jake.champlin.27@xxxxxxxxx
> 8123742937
> <MuttClient>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/