Re: linux-next: Tree for Jan 18 [MODSIGN: KEYS:]

[Sedat Dilek]

On Sat, Jan 19, 2013 at 12:04 AM, Sedat Dilek <sedat.dilek@xxxxxxxxx> wrote:
> On Fri, Jan 18, 2013 at 11:54 PM, David Howells <dhowells@xxxxxxxxxx> wrote:
>> Sedat Dilek <sedat.dilek@xxxxxxxxx> wrote:
>>
>>> Culprit seems to be...
>>>
>>> commit d6941c0c6bd42c725e45240a86c4add92e9bfb3e
>>> "KEYS: Separate the kernel signature checking keyring from module signing"
>>
>> Try updating.  I pushed a new version out today.  This is now at commit ID
>> c82af351e270e0d95059d09a1975b61494fbbcd7.
>>
>
> Thanks for the information!
>
> OK, I see... s/select/depends on...
>
>  +config SYSTEM_TRUSTED_KEYRING
>  +      bool "Provide system-wide ring of trusted keys"
> -+      select KEYS
> ++      depends on KEYS
>
> That should fix it :-).
> I set SYSTEM_TRUSTED_KEYRING=y in kernel-config.
>
> BAD: http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=patch;h=d6941c0c6bd42c725e45240a86c4add92e9bfb3e
>
> GOOD: http://git.kernel.org/?p=linux/kernel/git/dhowells/linux-modsign.git;a=patch;h=c82af351e270e0d95059d09a1975b61494fbbcd7
>

I tried to revert the bad commit and replace it with the good one, but
this seems to be more work.
So, I fixed it up like in the attached patch.

- Sedat -

> - Sedat -
>
>> David

Attachment: 0001-KEYS-Fix-build-error-when-SYSTEM_TRUSTED_KEYRING-n.patch
Description: Binary data