Re: [PATCH] ACPI / scan: Drop acpi_bus_add() and use acpi_bus_scan()instead (was: Re: [PATCH] ACPI / scan: Fold acpi_bus_scan() into acpi_bus_add())

[Yinghai Lu]

On Fri, Jan 18, 2013 at 1:55 PM, Rafael J. Wysocki <rjw@xxxxxxx> wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> Subject: ACPI / scan: Drop acpi_bus_add() and use acpi_bus_scan() instead
>
> The only difference between acpi_bus_scan() and acpi_bus_add() is the
> invocation of acpi_update_all_gpes() in the latter which in fact is
> unnecessary, because acpi_update_all_gpes() has already been called
> by acpi_scan_init() and the way it is implemented guarantees the next
> invocations of it to do nothing.
>
> For this reason, drop acpi_bus_add() and make all its callers use
> acpi_bus_scan() directly instead of it.  Additionally, rearrange the
> code in acpi_scan_init() slightly to improve the visibility of the
> acpi_update_all_gpes() call in there.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> ---
>  drivers/acpi/acpi_memhotplug.c     |    2 -
>  drivers/acpi/container.c           |    2 -
>  drivers/acpi/dock.c                |    2 -
>  drivers/acpi/processor_driver.c    |    2 -
>  drivers/acpi/scan.c                |   54 +++++++++++++++----------------------
>  drivers/pci/hotplug/acpiphp_glue.c |    4 +-
>  drivers/pci/hotplug/sgi_hotplug.c  |    4 +-
>  include/acpi/acpi_bus.h            |    2 -
>  8 files changed, 31 insertions(+), 41 deletions(-)

Acked-by: Yinghai Lu <yinghai@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/