Re: [PATCH 0/4] OPP usage fixes for RCU locking

From: Rafael J. Wysocki
Date: Fri Jan 18 2013 - 17:22:15 EST


On Friday, January 18, 2013 01:52:31 PM Nishanth Menon wrote:
> Hi,
> Despite being documented in function documentation and in
> Documentation/power/opp.txt, many of the users of OPP APIs
> dont honor RCU lock usage appropriately.
>
> This recently appeared in IRC discussion earlier today [1].
> I did an audit of current usage and the following series
> is a result of this.
>
> NOTE:
> 1. The patch "PM / devfreq: exynos4_bus: honor RCU lock usage" has only
> been build tested as I dont have an exynos platform to try it on. I have
> tried to make it as least intrusive as possible and at least reviewed
> to ensure I haven't screwed anything up.
>
> Other than this, I have added appropriate tested by information in requisite
> patches.

Thanks for the fixes.

MyungJoo, do you want me to take the devfreq ones too?

Rafael


> Series is based off: v3.8-rc4 tag
> Also available in the following location[2]:
> https://github.com/nmenon/linux-2.6-playground branch: post/pm/opp-fixes-v1
>
> Nishanth Menon (4):
> cpufreq: OMAP: use RCU locks around usage of OPP
> cpufreq: cpufreq-cpu0: use RCU locks around usage of OPP
> PM / devfreq: add locking documentation for recommend_opp
> PM / devfreq: exynos4_bus: honor RCU lock usage
>
> drivers/cpufreq/cpufreq-cpu0.c | 5 +++
> drivers/cpufreq/omap-cpufreq.c | 3 ++
> drivers/devfreq/devfreq.c | 5 +++
> drivers/devfreq/exynos4_bus.c | 94 ++++++++++++++++++++++++++++------------
> 4 files changed, 80 insertions(+), 27 deletions(-)
>
> [1] http://www.beagleboard.org/irclogs/index.php?date=2013-01-18#T14:14:07
> [2] https://github.com/nmenon/linux-2.6-playground/commits/post/pm/opp-fixes-v1
>
> Regards,
> Nishanth Menon
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/