Re: [RFC][PATCH 0/3] staging: alarm-dev: Cleanups and compat_ioctlsupport (v2)

[Arve Hjønnevåg]

On Thu, Jan 17, 2013 at 5:09 PM, John Stultz <john.stultz@xxxxxxxxxx> wrote:
> On 01/17/2013 04:48 PM, Greg KH wrote:
>>
>> On Fri, Jan 11, 2013 at 03:46:21PM -0800, John Stultz wrote:
>>>
>>> Here is the second revision at implementing compat_ioctl support for
>>> Android's alarm-dev driver in staging.
>>>
>>> The first patch removes the pre-Android 1.0 _OLD ioctls, per Colin's
>>> suggestion. Then the second patch does some refactoring to cleanup
>>> and separate the copying of user data from the logic, and the final
>>> patch adds the compat_ioctl support.
>>>
>>> I've tested this with a trivial unit test compiled for both 32bit
>>> and 64bit on a x86_64 kernel, and it looks ok, but closer review
>>> would be appreciated to make sure I didn't break anything.
>>>
>>> Additional feedback or thoughts would be welcome!
>>
>> These look fine to me, want me to apply them to my -next tree for 3.9?
>
>
> Yea, sure. I was going to resend tomorrow without the RFC tag.
>
> Colin, Arve: No objections?
>

Looks OK to me, but have not tested them.

-- 
Arve Hjønnevåg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/