Re: [PATCH v7 3/4] block: implement runtime pm strategy

From: Alan Stern
Date: Fri Jan 18 2013 - 10:26:25 EST


On Fri, 18 Jan 2013, Aaron Lu wrote:

> > Either you have to make sure the q->nr_pending is always correct, even
> > when runtime PM isn't being used, or else the caller has to make sure
> > that no I/O takes place before blk_pm_runtime_init is called.
>
> I think we can say:
> blk_pm_runtime_init can't be called after any requests have been
> submitted but not finished.
> Sounds more accurate?

Okay. I think you can add (in parentheses) that in most cases drivers
should call the routine before any I/O has taken place.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/