Re: [PATCH 1/2] regulator: wm8994: Convert wm8994_ldo2_ops to useregulator_list_voltage_linear

[Mark Brown]

On Fri, Jan 18, 2013 at 11:58:33AM +0800, Axel Lin wrote:

> +	/* LDO2, id starts from 0 */
> +	if (id == 1) {
> +		switch (wm8994->type) {
> +		case WM8994:
> +			wm8994_ldo_desc[id].min_uV = 900000;
> +			wm8994_ldo_desc[id].uV_step = 100000;
> +			break;

This isn't going to work in the (admittedly unlikely) case where we have
two different devices using this driver in the system.  We shouldn't be
modifying static data like this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/