Re: [PATCH 2/3] workqueue, async: implement work/async_current_func()

[Tejun Heo]

On Thu, Jan 17, 2013 at 07:18:26PM -0800, Linus Torvalds wrote:
> I'm not sure I understand what you mean? Do you mean trying to limit
> work_current_func() to only be accessible to the async code? You'd
> have to make some kind of private header file under kernel/ for that,
> but I guess that would work fine. We already do something similar
> inside filesystems etc, where they have their own local headers.

Yeap, and I'm unsure whether it's worth introducing a new internal
header file.

> Yes, yes, some globally optimizing compiler could sort it all out, but
> I'd personally be inclined to just move all the structure definitions
> into kernel/worker.h, and make the code be inline functions. The only
> actual current *user* would also be in the kernel/ subdirectory, and
> we don't know if we'd ever want to really expand it past there.
> 
> Hmm?

If we're gonna make it kernel/ internal thing with internal header, we
definitely can go all the way.  It's a bit meh because the code path
involved is very cold.  Hmm... I'll make it that way.  I like how it
keeps the thing apparently internal.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/