Re: [PATCH] drivers: avoid use after free of a pinctrl contextpointer

From: Greg Kroah-Hartman
Date: Thu Jan 17 2013 - 20:37:38 EST


On Wed, Jan 16, 2013 at 05:22:34PM +0100, Guennadi Liakhovetski wrote:
> During probing, pinctrl context is allocated and assigned to the struct
> device::pins pointer. If probing fails or if the driver is later unbound
> and re-probed again, the memory is freed, but the pointer is not cleared.
> On a repeated probing attempt a non-NULL pointer indicates an already
> allocated context, which then gets used. To avoid this the pointer must
> be cleared.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
> ---
> drivers/base/dd.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)

This can't go through my tree, as it breaks the build. Please send it
to whereever the pinctrl code is coming from.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/