Re: [PATCH] drm/radeon: fix NULL pointer dereference in UMS mode inradeon_cs_parser_fini()

[Shuah Khan]

On Wed, 2013-01-16 at 21:06 -0600, Ilija Hadzic wrote:
> Actually, the code path affected by your patch is not executed in UMS mode 
> at all. Notice that radeon_cs_parser_fini is only called from 
> radeon_cs_ioctl which is a KMS-only ioctl (see radeon_kms.c).
> 
> The equivalent of the fix you are trying to do is in
> a6b7e1a02b77ab8fe8775d20a88c53d8ba55482e (function patched by that one is 
> the one used by legacy-CS ioctl), which you should go together 
> with ff4bd0827764e10a428a9d39e6814c5478863f94 if you are backporting UMS 
> fixes to 3.7. Both are needed to prevent kernel crashes in UMS mode.
> 
> -- Ilija

Thanks. I will take a look at a6b7e1a02b77ab8fe8775d20a88c53d8ba55482e.
I sent back-ported ff4bd0827764e10a428a9d39e6814c5478863f94 patch to
stable and I will back-port and send
a6b7e1a02b77ab8fe8775d20a88c53d8ba55482e as well.

-- Shuah


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/