Re: [PATCH] MODSIGN: Add TAINT_NOKEY_MODULE

[Dave Jones]

On Thu, Jan 17, 2013 at 11:27:27AM +1030, Rusty Russell wrote:
 
 > taint: add explicit flag to show whether lock dep is still OK.
 > 
 > Fix up all callers as they were before, with make one change: an
 > unsigned module taints the kernel, but doesn't turn off lockdep.
 > 
 > Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
 
This made my brain itch a little until I got to the bottom of the
patch and saw the new definition of add_taint.  Perhaps instead of
false/true, we have LOCKDEP_LIVES/LOCKDEP_DIES or similar defines
to make it clearer what's actually happening without having to
go read the function ?

 > + * If something bad has gone wrong, you'll want @lockdebug_ok = false, but for
 > + * some notewortht-but-not-corrupting cases, it can be set to true.
 > + */

'noteworthy'

	Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/