Re: [PATCH 06/11] spi/pxa2xx: use the private DMA API only whenCONFIG_ARCH_PXA is set

[Linus Walleij]

On Mon, Jan 7, 2013 at 11:44 AM, Mika Westerberg
<mika.westerberg@xxxxxxxxxxxxxxx> wrote:

> The PXA SPI driver uses PXA platform specific private DMA implementation
> which does not work on non-PXA platforms. In order to use this driver on
> other platforms we need to move the private DMA implementation into a
> separate functions that get stubbed out when !CONFIG_ARCH_PXA.
>
> While we are there we can kill the dummy DMA bits in pxa2xx_spi.h as they
> are not needed anymore for CE4100.
>
> Once this is done we can add the generic DMA engine support to the driver
> that allows usage of any DMA controller that implements DMA engine API.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> ---
>  drivers/spi/spi-pxa2xx.c       |  612 +++++++++++++++++++++++-----------------
>  include/linux/spi/pxa2xx_spi.h |   80 ------

Can you even break this out to its own file?

Like drivers/spi/spi-pxa2xx-pxadma.c/.h
with stubs in the header file or something so we need
no #ifdefs in the main driver file?

The kernel looks better after this patch anyway, so
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
in any case.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/