Re: [PATCH 03/10] goldfish: tty driver

[Alan Cox]

On Wed, 16 Jan 2013 19:01:22 +0200
Felipe Balbi <balbi@xxxxxx> wrote:

> Hi,
> 
> On Wed, Jan 16, 2013 at 04:59:03PM +0000, Alan Cox wrote:
> > +static int goldfish_tty_probe(struct platform_device *pdev)
> > +{
> > +	struct goldfish_tty *qtty;
> > +	int ret = -EINVAL;
> > +	int i;
> > +	struct resource *r;
> > +	struct device *ttydev;
> > +	void __iomem *base;
> > +	u32 irq;
> > +
> > +	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > +	if(r == NULL)
> > +		return -EINVAL;
> > +
> > +	base = ioremap(r->start, 0x1000);
> 
> missing request_mem_region(), in fact you could just use
> devm_request_and_ioremap().

Actually the reservation is already done by the bus driver. If it sees
the goldfish interface it reserves the entire chunk and the emulator then
tells it which is in each chunk of that range.

It's reserving it as the wrong type however so I do need to fix that.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/