Re: [PATCH 06/10] goldfish: emulated MMC device

From: Felipe Balbi
Date: Wed Jan 16 2013 - 12:26:41 EST


On Wed, Jan 16, 2013 at 05:27:01PM +0000, Alan Cox wrote:
> On Wed, 16 Jan 2013 19:18:39 +0200
> Felipe Balbi <balbi@xxxxxx> wrote:
>
> > Hi,
> >
> > On Wed, Jan 16, 2013 at 04:59:38PM +0000, Alan Cox wrote:
> > > +#define OMAP_MMC_CMDTYPE_BC 0
> > > +#define OMAP_MMC_CMDTYPE_BCR 1
> > > +#define OMAP_MMC_CMDTYPE_AC 2
> > > +#define OMAP_MMC_CMDTYPE_ADTC 3
> >
> > OMAP ?? :-) If you guys are emulating an OMAP mmc controller, why don't
> > you just re-use the omap mmc driver instead of duplicating the code ?
>
> It's not an OMAP controller, it just has some similar behaviours. I guess
> that's because the original Google emulation target was entirely ARM
> based.

fair enough, cheers

--
balbi

Attachment: signature.asc
Description: Digital signature