Re: Redefinition of struct in6_addr in <netinet/in.h> and<linux/in6.h>

From: Ben Hutchings
Date: Wed Jan 16 2013 - 10:47:02 EST


On Wed, 2013-01-16 at 23:21 +0900, YOSHIFUJI Hideaki wrote:
> Cong Wang wrote:
> > (Cc'ing some glibc developers...)
> >
> > Hello,
> >
> > In glibc source file inet/netinet/in.h and kernel source file
> > include/uapi/linux/in6.h, both define struct in6_addr, and both are
> > visible to user applications. Thomas reported a conflict below.
> >
> > So, how can we handle this? /me is wondering why we didn't see this
> > before.
[...]
> This is not a new issue. In addition to this,
> netinet/in.h also conflits with linux/in.h.
>
> We might have
> #if !defined(__GLIBC__) || !defined(_NETINET_IN_H)
> :
> #endif
> around those conflicting definitions in uapi/linux/in{,6}.h.

This only solves half the problem, as <netinet/in.h> might be included
after <linux/in.h>. Also, not all Linux userland uses glibc.

Ben.

--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/