Re: [PATCH] context_tracking: Add comments on interface and internals

From: Frederic Weisbecker
Date: Wed Jan 16 2013 - 09:57:53 EST


2013/1/16 Namhyung Kim <namhyung@xxxxxxxxxx>:
> Hi Frederic,
>
> On Wed, 16 Jan 2013 13:32:57 +0100, Frederic Weisbecker wrote:
>> This subsystem lacks many explanations on its purpose and
>> design. Add these missing comments.
>>
>> v3: Fix the "hook" based naming as per Ingo's suggestion
> [snip]
>> +/**
>> + * context_tracking_task_switch - context switch the syscall callbacks
>
> To be more kernel-doc-friendly, it'd better adding descriptions for
> arguments too:
>
> @prev: the task that is being switched out
> @next: the task we are going to switch to

Right, I'm fixing that.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/