Re: [PATCH 3/4] pinctrl: add abx500 pinctrl driver core

[Lee Jones]

> > +static int abx500_gpio_irq_init(struct abx500_pinctrl *pct)
> ...
> > +#ifdef CONFIG_ARM
> > +		set_irq_flags(irq, IRQF_VALID);
> > +#else
> > +		irq_set_noprobe(irq);
> > +#endif
> 
> I assume that ifdef is always set one particular way?
> 
> > +static void abx500_gpio_irq_remove(struct abx500_pinctrl *pct)
> ...
> > +#ifdef CONFIG_ARM
> > +		set_irq_flags(irq, 0);
> > +#endif
> 
> Same there.

You can safely ignore anything to do with IRQs in this patch-set, as
I have a follow-up one (originally written for the old gpio-ab8500
driver - which this is the successor to), which pulls it all out and
applies to the ab8500-core driver instead.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/