Re: [BUG Fix Patch 1/6] Bug fix: Hold spinlock across find|remove/sys/firmware/memmap/X operation.

[Tang Chen]

On 01/16/2013 06:26 AM, Julian Calaby wrote:
> Hi Tang,
>
> One minor point.
>
> >   /*
> > - * Search memmap entry
> > + * firmware_map_find_entry: Search memmap entry.
> > + * @start: Start of the memory range.
> > + * @end:   End of the memory range (exclusive).
> > + * @type:  Type of the memory range.
> > + *
> > + * This function is to find the memmap entey of a given memory range.
> > + * The caller must hold map_entries_lock, and must not release the lock
> > + * until the processing of the returned entry has completed.
> > + *
> > + * Return pointer to the entry to be found on success, or NULL on failure.
>
> Why not make this completely kernel-doc compliant as you're already
> re-writing the comment?

Hi Julian,

Thank you for reminding me this. I think I may have some more problems
like this. I'll post a patch to fix as many of them as I can. :)

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/