Re: [PATCH 1/1] clk-divider: fix is_power_of_two()

[Mike Turquette]

Quoting Joe Perches (2013-01-15 10:31:05)
> On Tue, 2013-01-15 at 10:28 +0000, James Hogan wrote:
> > The macro is_power_of_two() in clk-divider.c was defined as !(i & ~i)
> > which is always true. Correct it to !(i & (i - 1)).
> []
> > diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c
> []
> > @@ -29,8 +29,8 @@
> []
> > -#define div_mask(d)  ((1 << (d->width)) - 1)
> > -#define is_power_of_two(i)   !(i & ~i)
> > +#define div_mask(d)  ((1 << ((d)->width)) - 1)
> > +#define is_power_of_two(i)   (!((i) & ((i) - 1)))
> 
> Use is_power_of_2 in log2.h instead?

Both are fine suggestions.  How about I apply the below patch?

Thanks,
Mike