Re: [PATCH v8 08/22] PCI, acpiphp: Separate out hot-add support ofpci host bridge

From: Yinghai Lu
Date: Tue Jan 15 2013 - 10:54:13 EST


On Mon, Jan 14, 2013 at 10:44 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> On Sat, Jan 12, 2013 at 3:18 PM, Rafael J. Wysocki <rjw@xxxxxxx> wrote:
>>> @@ -673,3 +673,223 @@ int __init acpi_pci_root_init(void)
>>>
>>> return 0;
>>> }
>>> +
>>> +/*
>>> + * Separated from drivers/pci/hotplug/acpiphp_glue.c
>>> + * only support root bridge
>>> + */
>>
>> This comment will be useless after applying the patch.
>>
>>> +
>>> +static LIST_HEAD(acpi_root_bridge_list);
>>> +struct acpi_root_bridge {
>>> + struct list_head list;
>>> + acpi_handle handle;
>>> + u32 flags;
>>> +};
>>
>> We have struct acpi_pci_root already. Why do we need this in addition?
>
> will address that in following patch.

please check if you are ok with merging attached 5 patches in to one
patches instead.

Thanks

Yinghai

Attachment: pci_root_acpiphp_split_before_jiang_hotplug_rework.patch
Description: Binary data

Attachment: pci_root_hp_1.patch
Description: Binary data

Attachment: kill_remove_acpi_root_bridge.patch
Description: Binary data

Attachment: root_bridge_remove_2.patch
Description: Binary data