Re: [PATCH] dw_dmac: don't exceed AHB master number in dwc_get_data_width

From: Andy Shevchenko
Date: Tue Jan 15 2013 - 04:36:01 EST


On Tue, Jan 15, 2013 at 11:09 AM, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> On 15 January 2013 14:38, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:
>> You forgot the mem2mem type of transfers where we have no information
>> about masters except default settings. Otherwise there is the case of
>> custom slave config absence when we supply only request line via
>> slave_id.
>
> Okay, but even for mem2mem you have just got the right bus width by
> selecting same master. But are you programming same masters in control
> register? I can't see that :(

Oops. Seems this patch does not cover the CTL lo register value.
Thank you for pointing this out. I will think how to make the fix better.

--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/