Re: [PATCH v7u1 22/31] x86, boot: add fields to support load bzImageand ramdisk above 4G

From: Borislav Petkov
Date: Mon Jan 14 2013 - 15:26:13 EST


On Mon, Jan 14, 2013 at 12:14:18PM -0800, Yinghai Lu wrote:
> no, no, no.
>
> bootloader does not need to know sentinel, and they only need to do:
> clearing boot_param buffer and copying setup_header only
>
> even new bootloader is not supposed to know sentinel ...

Ah, ok. I thought something was fishy because if bootloaders would know
about it, they'd copy setup_header and zero out the sentinel only, to
force the kernel to use crappy ext_* etc. values.

How about this:

"The sentinel variable is set by the linker script to 0xff. It is
supposed to be used for catching bootloaders which just copy the
setup_header portion and don't clear the whole boot_params buffer as
they are supposed to. Such bootloaders will leave the sentinel to its
initial value of 0xff and in this case, the kernel will assume that some
fields in boot_params have invalid values and zero them out."

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/