Re: [PATCH v7u1 22/31] x86, boot: add fields to support load bzImageand ramdisk above 4G

[H. Peter Anvin]

On 01/14/2013 10:57 AM, Yinghai Lu wrote:
>>
>> If the sentinel is flagged, zero *all fields not explicitly set by the
>> broken versions of kexec*, not just your new "ext" fields.
> 
> other fields are pad* fields, so do we zero out them
> with memset with exact address?
> so next times, when someone change pad fields to other ext_*,
> they don't need to change code again here.
> 

No, there were other fields that were also left uninitialized, per your
analysis from last year.  I don't remember the details, but I seem to
recall they included the EFI and graphics-related fields.

So yes, just zero them all out.

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/